Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/dns: OSConfig with Hosts formats as gibberish #5669

Closed
bradfitz opened this issue Sep 16, 2022 · 0 comments · Fixed by #5766
Closed

net/dns: OSConfig with Hosts formats as gibberish #5669

bradfitz opened this issue Sep 16, 2022 · 0 comments · Fixed by #5766
Assignees
@maisem

Comments

@bradfitz
Copy link
Member 

type OSConfig struct {
	// Hosts is a map of DNS FQDNs to their IPs, which should be added to the
	// OS's hosts file. Currently, (2022-08-12) it is only populated for Windows
	// in SplitDNS mode and with Smart Name Resolution turned on.
	Hosts []*HostEntry

write test for m.logf("OScfg: %+v", ocfg) that it isn't a bunch of pointers
andrew-d added a commit that referenced this issue Sep 27, 2022
@andrew-d
net/dns: format OSConfig correctly with no pointers
9909c5e 
Fixes #5669

Signed-off-by: Andrew Dunham <andrew@du.nham.ca>
andrew-d added a commit that referenced this issue Sep 27, 2022
@andrew-d
net/dns: format OSConfig correctly with no pointers
724a25a 
Fixes #5669

Signed-off-by: Andrew Dunham <andrew@du.nham.ca>
@andrew-d andrew-d mentioned this issue Sep 27, 2022
Merged
andrew-d added a commit that referenced this issue Sep 27, 2022
@andrew-d
net/dns: format OSConfig correctly with no pointers
c0fd70d 
Fixes #5669

Signed-off-by: Andrew Dunham <andrew@du.nham.ca>
andrew-d added a commit that referenced this issue Sep 27, 2022
@andrew-d
net/dns: format OSConfig correctly with no pointers
110cc41 
Fixes #5669

Signed-off-by: Andrew Dunham <andrew@du.nham.ca>
andrew-d added a commit that referenced this issue Sep 27, 2022
@andrew-d
net/dns: format OSConfig correctly with no pointers (#5766)
a5fab23 
Fixes #5669

Signed-off-by: Andrew Dunham <andrew@du.nham.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maisem maisem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

net/dns: format OSConfig correctly with no pointers tailscale/tailscale
2 participants
@bradfitz @maisem