Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: broken Chinese characters with shared devices #6824

Closed
garrett-ts opened this issue Dec 21, 2022 · 3 comments
Closed

Android: broken Chinese characters with shared devices #6824

garrett-ts opened this issue Dec 21, 2022 · 3 comments
Labels

Comments

@garrett-ts
Copy link

What is the issue?

When a device from a user with Chinese characters is shared, Android doesn't know how to display those characters, instead showing as "☒"

Screenshot_20221221-152128

Steps to reproduce

No response

Are there any recent changes that introduced the issue?

No response

OS

Android

OS version

No response

Tailscale version

No response

Bug report

No response

@bradfitz
Copy link
Member

Hey @eliasnaur, is this a known issue? (or something that's since been fixed and we're using something old?)

@eliasnaur
Copy link
Contributor

Indeed, font fallback has been implemented in recent Gio versions.

@DentonGentry DentonGentry added L1 Very few Likelihood P2 Aggravating Priority level T1 Localization Issue type T2 Visual Polish Issue type T5 Usability Issue type and removed needs-triage labels Dec 24, 2022
DentonGentry added a commit to tailscale/tailscale-android that referenced this issue Dec 25, 2022
There were several API changes since we last updated. We
followed examples from the upstream Gio repository:

1. Replace unit.Px with unit.Dp
   Followed example in
   gioui/gio@3d37491

2. op.Offset now takes int coordinates instead of float.
   Followed example in
   gioui/gio@a63e0cb

3. clip.RRect now takes int coordinates instead of float.
   Followed example in
   gioui/gio@48a8540

4. Replace system.CommandEvent with key.Event
   Followed example in
   gioui/gio@6c76fa6

Updates tailscale/tailscale#6824

Signed-off-by: Denton Gentry <dgentry@tailscale.com>
DentonGentry added a commit to tailscale/tailscale-android that referenced this issue Dec 25, 2022
There were several API changes since we last updated. We
followed examples from the upstream Gio repository:

1. Replace unit.Px with unit.Dp.
   Followed example in:
   gioui/gio@3d37491

2. op.Offset now takes int coordinates instead of float.
   Followed example in:
   gioui/gio@a63e0cb

3. clip.RRect now takes int coordinates instead of float.
   Followed example in:
   gioui/gio@48a8540

4. Replace system.CommandEvent with key.Event
   Followed example in:
   gioui/gio@6c76fa6

Updates tailscale/tailscale#6824

Signed-off-by: Denton Gentry <dgentry@tailscale.com>
DentonGentry added a commit to tailscale/tailscale-android that referenced this issue Dec 26, 2022
There were several API changes since we last updated. We
followed examples from the upstream Gio repository:

1. Replace unit.Px with unit.Dp.
   Followed example in:
   gioui/gio@3d37491

2. op.Offset now takes int coordinates instead of float.
   Followed example in:
   gioui/gio@a63e0cb

3. clip.RRect now takes int coordinates instead of float.
   Followed example in:
   gioui/gio@48a8540

4. Replace system.CommandEvent with key.Event.
   Followed example in:
   gioui/gio@6c76fa6

Updates tailscale/tailscale#6824

Signed-off-by: Denton Gentry <dgentry@tailscale.com>
DentonGentry added a commit to tailscale/tailscale-android that referenced this issue Dec 29, 2022
There were several API changes since we last updated. We
followed examples from the upstream Gio repository:

1. Replace unit.Px with unit.Dp.
   Followed example in:
   gioui/gio@3d37491

2. op.Offset now takes int coordinates instead of float.
   Followed example in:
   gioui/gio@a63e0cb

3. clip.RRect now takes int coordinates instead of float.
   Followed example in:
   gioui/gio@48a8540

4. Replace system.CommandEvent with key.Event.
   Followed example in:
   gioui/gio@6c76fa6

Updates tailscale/tailscale#6824

Signed-off-by: Denton Gentry <dgentry@tailscale.com>

Signed-off-by: Denton Gentry <dgentry@tailscale.com>
@DentonGentry
Copy link
Contributor

Tailscale 1.37.108 contains the Gio HEAD as of 11 Feb 2023, which should resolve this. Please reopen if not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants