Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR: Allow Key Duration To Be Passed As Parameter in Tailscale Client #7965

Closed
matty234 opened this issue Apr 25, 2023 · 0 comments · Fixed by #7143
Closed

FR: Allow Key Duration To Be Passed As Parameter in Tailscale Client #7965

matty234 opened this issue Apr 25, 2023 · 0 comments · Fixed by #7143
Labels
fr Feature request needs-triage

Comments

@matty234
Copy link
Contributor

What are you trying to do?

Provide a duration until expiry for a new key generated through the API.

How should we solve this?

We should add this as a parameter to the CreateKey function.

What is the impact of not solving this?

No response

Anything else?

I've already created a PR for this issue: #7143
@matty234 matty234 added fr Feature request needs-triage labels Apr 25, 2023
@matty234 matty234 mentioned this issue Apr 25, 2023
Merged
DentonGentry pushed a commit that referenced this issue May 12, 2023
@matty234
client: allow the expiry time to be specified for new keys
9b6e486 
Adds a parameter for create key that allows a number of seconds
(less than 90) to be specified for new keys.

Fixes #7965

Signed-off-by: Matthew Brown <matthew@bargrove.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fr Feature request needs-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow the expiry time to be specified for new keys matty234/tailscale
1 participant
@matty234