-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If android intent is triggered more than once, a connecting loop is triggered and you can't disconnect #8013
Comments
Can't assign myself, but I'm fixing this bug that I introduced |
if start intent called more than once Fixes: tailscale/tailscale#8013 Signed-off-by: Brett Jenkins <brett@brettjenkins.co.uk>
Turns out there were still some cases where the bug would occur, also it turns out checking the status of a VPN connection isn't foolproof in android, so this is a safer way to fix it, we just ensure that the autoConnect var is set to false when disconnecting. Fixes: tailscale/tailscale#8013 Signed-off-by: Brett Jenkins <brett@brettjenkins.co.uk>
Turns out there were still some cases where the bug would occur, also it turns out checking the status of a VPN connection isn't foolproof in android, so this is a safer way to fix it, we just ensure that the autoConnect var is set to false when disconnecting. Fixes: tailscale/tailscale#8013 Signed-off-by: Brett Jenkins <brett@brettjenkins.co.uk>
@DentonGentry Hello, when could we expect the fix that @brettjenkins committed/checked in 3 weeks ago to be part of the build/new version? I'm using Android 11 Tailscale app version 1.42.0 and I'm having this issue still when trying to use the disconnect intent, it disconnects and then it reconnects unexpectedly. Thank you. UPDATE: I got it working without the fix, all you need to do is to send the disconnect intent twice, just give like a 5 seconds wait after each send intent... works like a charm. |
Just tried this out, can confirm that it worked for me! Thanks! Edit: might have spoken too soon. It's not working anymore for me. Even going into the main app and trying to deactivate the VPN on the main window is not working. It just reactivates itself immediately... |
This didn't work either. |
What tailscale app version are you using? |
Tailscale App Version: 1.44.1 |
I'm also experiencing the same thing, none of the aforementioned workarounds work for me. Tailscale Version: 1.44.1-ta377e1363-g584245cc823 |
Well I have a different phone/os and I'm using Macrodroid. Maybe try Macrodroid too. |
* startvpnworker.java: prevent connecting loops If start intent called more than once. Turns out there were still some cases where the bug would occur, also it turns out checking the status of a VPN connection isn't foolproof in android, so this is a safer way to fix it, we just ensure that the autoConnect var is set to false when disconnecting. Fixes: tailscale/tailscale#8013 Signed-off-by: Brett Jenkins <brett@brettjenkins.co.uk>
What is the issue?
As mentioned on tailscale/tailscale-android#87
If a connect intent is triggered more than once, or while the VPN is already connected, on disconnect the VPN will reconnect.
Steps to reproduce
No response
Are there any recent changes that introduced the issue?
tailscale/tailscale-android#87
OS
Android
OS version
No response
Tailscale version
No response
Other software
No response
Bug report
No response
The text was updated successfully, but these errors were encountered: