Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: double opt-in to add nodes to tailnets #8823

Open
ALightTechnologyAndServicesLimited opened this issue Aug 9, 2023 · 2 comments
Open
Labels
fr Feature request L2 Few Likelihood P2 Aggravating Priority level pending T0 New feature Issue type

Comments

@ALightTechnologyAndServicesLimited

What are you trying to do?

More secure way of pairing servers

How should we solve this?

I think re-gistering servers should be 2 way i.e

In the website allow copying some random GUID (don’t show the GUID in plain text).
In the server after tailscale up, prompt for the GUID, treat the GUID like password, allow pasting but don’t echo the GUID.
Generate another unique GUID on the server and display.
User copies the server-side GUID and pastes in the website.
Now pair the servers
Even if someone somehow steals the first GUID and pastes in their server, the second GUID generated by their server would be different and can’t be paired.

If someone steals the second guid, their browser-side first guid associated with their account would be different and can’t be paired.

What is the impact of not solving this?

Some pranker can try to pair someone else's server, ofcourse there would be a small window for them to do any harm, but still little risky.

Anything else?

No response

@DentonGentry
Copy link
Contributor

DentonGentry commented Aug 9, 2023

https://tailscale.com/kb/1226/tailnet-lock/ is one way to address concerns about adding nodes to tailnets.
https://tailscale.com/kb/1099/device-approval/ is another.

@DentonGentry DentonGentry changed the title FR: FR: double opt-in to add nodes to tailnets Aug 9, 2023
@DentonGentry DentonGentry added L2 Few Likelihood P2 Aggravating Priority level T0 New feature Issue type pending and removed needs-triage labels Aug 9, 2023
@ALightTechnologyAndServicesLimited
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fr Feature request L2 Few Likelihood P2 Aggravating Priority level pending T0 New feature Issue type
Projects
None yet
Development

No branches or pull requests

3 participants
@DentonGentry @ALightTechnologyAndServicesLimited and others