Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/web: rename Disconnect to Logout #10756

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

soniaappasamy
Copy link
Member

For consistency w/ the CLI command. And to be more accurate to what is actually happening on this action - node key is expired.

Updates #10261

Copy link
Contributor

@sonovawolf sonovawolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some corrections

client/web/src/components/views/device-details-view.tsx Outdated Show resolved Hide resolved
client/web/src/components/views/device-details-view.tsx Outdated Show resolved Hide resolved
client/web/src/components/views/device-details-view.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@sonovawolf sonovawolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed more improvements on Slack, and pending those I approve!

For consistency w/ the CLI command. And to be more accurate to what
is actually happening on this action - node key is expired.

Also updates the disconnected view shown after logout.

Updates #10261

Signed-off-by: Sonia Appasamy <sonia@tailscale.com>
@soniaappasamy soniaappasamy force-pushed the soniaappasamy/rename-logout-button branch from 7c1f395 to 0a5c234 Compare January 5, 2024 19:42
@soniaappasamy
Copy link
Member Author

Updated!

@soniaappasamy soniaappasamy merged commit 55d302b into main Jan 8, 2024
46 checks passed
@soniaappasamy soniaappasamy deleted the soniaappasamy/rename-logout-button branch January 8, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants