Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgengine/router: fix ip rule restoration #10858

Merged

Conversation

jasonwbarnett
Copy link
Contributor

Fixes #10857

Fixes tailscale#10857

Signed-off-by: Jason Barnett <J@sonBarnett.com>
Copy link
Contributor

@KevinLiang10 KevinLiang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me. Also tested the new code, restoring works fine and nothing new that seems strange pops up during testing.

@KevinLiang10 KevinLiang10 merged commit 4d66841 into tailscale:main Feb 15, 2024
1 check passed
@jasonwbarnett jasonwbarnett deleted the jwb/bugfix/on-ip-rule-delete branch February 17, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wgengine/router: two ip rules need to be deleted before ip rules are restored
2 participants