wgengine/netstack: expose gVisor metrics through expvar #10899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When tailscaled is run with "-debug 127.0.0.1:12345", these metrics are
available at:
http://localhost:12345/debug/metrics
Updates #8210
Signed-off-by: Andrew Dunham <andrew@du.nham.ca>
Change-Id: I19db6c445ac1f8344df2bc1066a3d9c9030606f8
oxtoacart
approved these changes
Jan 19, 2024
|
Is it deliberate that these metrics are only exposed via the local debug server and not via c2n? |
Mostly, because it was a straightforward prototype. We do probably want to expose these in some other way, whether that be client metrics, C2N, or something else; I don't actually know what our current recommended approach is for metrics collection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tailscaled is run with "-debug 127.0.0.1:12345", these metrics are available at:
http://localhost:12345/debug/metrics
Updates #8210
Change-Id: I19db6c445ac1f8344df2bc1066a3d9c9030606f8