cmd/dist: fix --synology-package-center flag #11062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willnorris
reviewed
Feb 8, 2024
|
Putting in draft for now because this is also broken on the corp side (for both |
|
Aha! After more investigation, I found an issue open in the ffcli lib that explains what's happening here: peterbourgon/ff#124 Running this works: While running this does not: Although confusing, I think this CLI is in an okayish place as-is then, as long as you interface with the flags in the correct way. I'm gonna repurpose this PR to better document this, and more clearly callout whether a Synology build was run for "package center" versus "sideloading". Attempting to make usage less confusing. |
Update logs for synology builds to more clearly callout which variant is being built. The two existing variants are: 1. Sideloaded (can be manual installed on a device by anyone) 2. Package center distribution (by the tailscale team) Updates #cleanup Signed-off-by: Sonia Appasamy <sonia@tailscale.com>
soniaappasamy
force-pushed
the
soniaappasamy/fix-synology-package-center-build
branch
from
5dd2ff2
to
aaabdca
Compare
willnorris
approved these changes
Feb 8, 2024
soniaappasamy
deleted the
soniaappasamy/fix-synology-package-center-build
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the following to build new Synology package center releases previously ignored the
--synology-package-centerflag, which is vital for making app store releases.This change updates
getTargetsto accept the args passed into the build command. And then checks for existance of the synology flag directly. This also allows us to move the synology flag out of the dist main func and into the CLI func where all other build flags are defined.Can skip-issubot