safeweb: init #11467
Merged
safeweb: init #11467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickod
force-pushed
the
patrickod/safeweb
branch
from
63e2c22
to
7c02b54
Compare
awly
reviewed
Mar 20, 2024
patrickod
force-pushed
the
patrickod/safeweb
branch
2 times, most recently
from
b4164ce
to
82fb019
Compare
patrickod
force-pushed
the
patrickod/safeweb
branch
2 times, most recently
from
f1f050e
to
c6b6a2a
Compare
awly
reviewed
Mar 21, 2024
patrickod
force-pushed
the
patrickod/safeweb
branch
from
c6b6a2a
to
2485c54
Compare
creachadair
reviewed
Mar 21, 2024
patrickod
force-pushed
the
patrickod/safeweb
branch
4 times, most recently
from
142e052
to
16dcb34
Compare
patrickod
force-pushed
the
patrickod/safeweb
branch
from
16dcb34
to
109b7b9
Compare
creachadair
reviewed
Mar 22, 2024
creachadair
reviewed
Mar 22, 2024
patrickod
force-pushed
the
patrickod/safeweb
branch
from
109b7b9
to
1279c7d
Compare
patrickod
force-pushed
the
patrickod/safeweb
branch
2 times, most recently
from
648368f
to
817c722
Compare
patrickod
force-pushed
the
patrickod/safeweb
branch
from
817c722
to
a4f323f
Compare
creachadair
reviewed
Mar 26, 2024
patrickod
force-pushed
the
patrickod/safeweb
branch
2 times, most recently
from
2d00ac9
to
3981406
Compare
creachadair
reviewed
Mar 26, 2024
creachadair
approved these changes
Mar 26, 2024
Updates tailscale/corp#8027 Safeweb is a wrapper around http.Server & tsnet that encodes some application security defaults. Safeweb asks developers to split their HTTP routes into two http.ServeMuxs for serving browser and API-facing endpoints repsectively. It then wraps these HTTP routes with the context-appropriate security controls. safeweb.Server#Serve will serve the HTTP muxes over the provided listener. Caller are responsible for creating and tearing down their application's listeners. Applications being served over HTTPS that wish to implement HTTP redirects can use the Server#HTTPRedirect handler to do so. Signed-off-by: Patrick O'Doherty <patrick@tailscale.com>
patrickod
force-pushed
the
patrickod/safeweb
branch
from
3981406
to
3c11465
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates https://github.com/tailscale/corp/issues/8027
Implement a first pass of "safeweb" per the "Secure Internal Web Applications by Default" eng doc.
Safeweb is a wrapper around http.Server & tsnet that encodes some
application security defaults.
Safeweb asks developers to split their HTTP routes into two
http.ServeMuxs for serving browser and API-facing endpoints
repsectively. It then wraps these HTTP routes with the
context-appropriate security controls.
safeweb.Server#Serve will serve the HTTP muxes over the provided
listener. Caller are responsible for creating and tearing down their
application's listeners. Applications being served over HTTPS that wish
to implement HTTP redirects can use the Server#HTTPRedirect handler to
do so.