ipn/ipnlocal: add c2n pprof option to force a GC #11479
Merged
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like net/http/pprof has. Updates tailscale/corp#18514 Change-Id: I264adb6dcf5732d19707783b29b7273b4ca69cf4 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
dsnet
approved these changes
Mar 21, 2024
dsnet
reviewed
Mar 21, 2024
| ) | ||
|
|
||
| func init() { | ||
| c2nLogHeap = func(w http.ResponseWriter, r *http.Request) { | ||
| // Support same optional gc parameter as net/http/pprof: |
There was a problem hiding this comment.
I thought net/http/pprof uses a "/gc" URL endpoint, rather than a URL query parameter?
There was a problem hiding this comment.
Not that I see. This code is straight from net/http/pprof. And docs say:
heap: A sampling of memory allocations of live objects. You can specify the gc GET parameter to run GC before taking the heap sample.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like net/http/pprof has.
Updates tailscale/corp#18514