net/tstun: use gaissmai/bart instead of tempfork/device #11488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxtoacart
force-pushed
the
oxtocart/allowed_ips_efficiency
branch
3 times, most recently
from
a85bb8b
to
fca027e
Compare
maisem
reviewed
Mar 22, 2024
maisem
reviewed
Mar 22, 2024
oxtoacart
force-pushed
the
oxtocart/allowed_ips_efficiency
branch
from
6affc07
to
44dbfb6
Compare
maisem
reviewed
Mar 22, 2024
net/tstun/wrap.go
Outdated
| count[v]++ | ||
| return true | ||
| }) | ||
| // count := map[netip.Addr]int{} |
There was a problem hiding this comment.
Let's not have commented out code here. This was to get the build passing in the patch 😅
We can track the counts when building the table and then just use the value directly here
net/tstun/wrap.go
Outdated
| } | ||
| if len(listenAddrs) == 0 && len(dstMasqAddrs) == 0 { | ||
| if len(listenAddrs) == 0 && needMasq { |
net/tstun/wrap.go
Outdated
| rt.InsertOrReplace(p.PublicKey, p.AllowedIPs...) | ||
| mak.Set(&dstMasqAddrs, p.PublicKey, addrToUse) | ||
| for _, ip := range p.AllowedIPs { | ||
| needMasq = true |
There was a problem hiding this comment.
Can probably do this outside the allowed ips loops
oxtoacart
force-pushed
the
oxtocart/allowed_ips_efficiency
branch
from
44dbfb6
to
8d68c40
Compare
This implementation uses less memory than tempfork/device, which helps avoid OOM conditions in the iOS VPN extension when switching to a Tailnet with ExitNode routing enabled. Updates tailscale/corp#18514 Signed-off-by: Percy Wegmann <percy@tailscale.com>
oxtoacart
force-pushed
the
oxtocart/allowed_ips_efficiency
branch
from
8d68c40
to
236c8b3
Compare
|
@maisem I've addressed your latest comments. |
|
Thanks for the review @maisem ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation uses less memory than tempfork/device, which helps avoid OOM conditions in the iOS VPN extension when switching to a Tailnet with ExitNode routing enabled.
Updates tailscale/corp#18514