Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/k8s-operator: redact auth key from debug logs #11523

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

irbekrm
Copy link
Contributor

@irbekrm irbekrm commented Mar 26, 2024

Ensure that when auth key is provided to operator's proxy as part of tailscaled config, we don't print it, when the config is being printed for debugging purposes.

What the output looks like now:

{"level":"debug","ts":"2024-03-26T14:47:36Z","logger":"service-reconciler","msg":"creating a new Secret for the proxy with tailscaled config {\"Version\":\"alpha0\",\"Locked\":false,\"AuthKey\":\"**redacted**\",\"Hostname\":\"kuard1\",\"acceptDNS\":false,\"acceptRoutes\":false}","service-ns":"default","service-name":"kuard1"}
{"level":"debug","ts":"2024-03-26T14:46:04Z","logger":"service-reconciler","msg":"patching the existing proxy Secret with tailscaled config {\"Version\":\"alpha0\",\"Locked\":false,\"AuthKey\":\"**redacted**\",\"Hostname\":\"kuard1\",\"acceptDNS\":false,\"acceptRoutes\":false}","service-ns":"default","service-name":"kuard1"}

Updates#cleanup

Updates#cleanup

Signed-off-by: Irbe Krumina <irbe@tailscale.com>
cmd/k8s-operator/sts.go Dismissed Show resolved Hide resolved
cmd/k8s-operator/sts.go Dismissed Show dismissed Hide dismissed
@irbekrm irbekrm merged commit 4cbef20 into main Mar 26, 2024
47 checks passed
@irbekrm irbekrm deleted the irbekrm/fix_key branch March 26, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants