cmd/{k8s-nameserver,k8s-operator},k8s-operator: reverts k8s nameserver functionality #11669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irbekrm
force-pushed
the
irbekrm/revert_nameserver
branch
from
e3151e5
to
39f2b57
Compare
rhealitycheck
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR temporarily reverts #11017 we weren't able to get in #11019 that would actually make the nameserver function or the infra changes to publish its images, so probably shouldn't release a not-yet-functioning feature in 1.64.
I will re-open it once we have more bandwidth for code reviews for the operator.