health: add warming-up warnable #12553
Open
+24
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bradfitz could I perhaps improve this by setting the Warnable to healthy as soon as IPNState is set to Running, if that verifies before 5 seconds have passed? Does Running mean that everything is ready to go? |
Updates #4136 Creates and exposes a 'fake' warnable that persists for the first 5 seconds of lifetime of the backend. This is used to silence spurious warnings while the backend is starting up. Signed-off-by: Andrea Gottardo <andrea@gottardo.me>
agottardo
force-pushed
the
angott/warming-up-warnable
branch
from
e672be5
to
eab52f7
Compare
bradfitz
reviewed
Jun 20, 2024
Comment on lines
+709
to
+714
| if t.ipnStateFirstSet.IsZero() { | ||
| // The first time we see an IPNState getting set, it means the backend is starting up. We store this timestamp. | ||
| // We use it to silence some warnings that are expected during startup. | ||
| t.ipnStateFirstSet = time.Now() | ||
| t.setUnhealthyLocked(warmingUpWarnable, nil) | ||
| } |
There was a problem hiding this comment.
I think we want to do this on any transition from wantRunning false to wantRunning true, not just once.
There was a problem hiding this comment.
Aargh, you're right. I'm used to our Apple platforms where there's always only one wantRunning for each process lifetime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #4136
Creates and exposes a 'fake' warnable that persists for the first 5 seconds of lifetime of the backend. This is used to silence spurious warnings while the backend is starting up.