Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh/tailssh: fix integration test #12562

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

irbekrm
Copy link
Contributor

@irbekrm irbekrm commented Jun 20, 2024

The new ssh integration test target is failing on main

$ make sshintegrationtest
# tailscale.com/ssh/tailssh [tailscale.com/ssh/tailssh.test]
ssh/tailssh/tailssh_integration_test.go:488:19: cannot use &testBackend{…} (value of type *testBackend) as ipnLocalBackend value in struct literal: *testBackend does not implement ipnLocalBackend (wrong type for method WhoIs)
                have WhoIs(netip.AddrPort) (tailcfg.NodeView, tailcfg.UserProfile, bool)
                want WhoIs(string, netip.AddrPort) (tailcfg.NodeView, tailcfg.UserProfile, bool)
make: *** [Makefile:113: sshintegrationtest] Error 1

presumably because of the order in which the PR with it and #12385 got merged.

Updates#cleanup

Updates#cleanup

Signed-off-by: Irbe Krumina <irbe@tailscale.com>
@irbekrm irbekrm requested a review from oxtoacart June 20, 2024 18:17
@irbekrm irbekrm merged commit 07063bc into main Jun 20, 2024
49 checks passed
@irbekrm irbekrm deleted the irbekrm/fix_ssh_integration_test branch June 20, 2024 18:30
@oxtoacart
Copy link
Contributor

Thanks @irbekrm !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants