cmd/tailscale/cli: remove special-casing of JS/WASM #5265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Who says we don't want the full CLI in the future? :) |
|
Fair enough. I can shelve this and clean up the direct |
mihaip
added a commit
that referenced
this pull request
Aug 2, 2022
Since we're keeping the JS support in the CLI (see #5265 (comment)), make sure it keeps building. Signed-off-by: Mihai Parparita <mihai@tailscale.com>
mihaip
added a commit
that referenced
this pull request
Aug 2, 2022
Since we're keeping the JS support in the CLI (see #5265 (comment)), make sure it keeps building. Signed-off-by: Mihai Parparita <mihai@tailscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're no longer compiling the entire CLI for WASM, so we can remove
some wrapper functions and GOOS checks.
Effectively reverts 75de4e9.
5df7ac7, eda647c
and other changes.
Fixes #5146
Signed-off-by: Mihai Parparita mihai@tailscale.com