ipn/ipnlocal: add support for multiple profiles #6022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maisem
force-pushed
the
maisem/fas2
branch
5 times, most recently
from
f99bf94
to
3b4e84a
Compare
bradfitz
reviewed
Oct 23, 2022
bradfitz
reviewed
Oct 23, 2022
bradfitz
reviewed
Oct 23, 2022
bradfitz
reviewed
Oct 23, 2022
bradfitz
reviewed
Oct 23, 2022
maisem
force-pushed
the
maisem/fas2
branch
3 times, most recently
from
6af1014
to
c4bf475
Compare
maisem
force-pushed
the
maisem/fas2
branch
2 times, most recently
from
10d4aec
to
17e9a06
Compare
mihaip
reviewed
Nov 3, 2022
maisem
force-pushed
the
maisem/fas2
branch
4 times, most recently
from
6d5497a
to
4246439
Compare
mihaip
reviewed
Nov 9, 2022
mihaip
reviewed
Nov 10, 2022
mihaip
reviewed
Nov 10, 2022
bradfitz
reviewed
Nov 11, 2022
bradfitz
reviewed
Nov 11, 2022
bradfitz
reviewed
Nov 11, 2022
maisem
force-pushed
the
maisem/fas2
branch
5 times, most recently
from
11f35db
to
3b7e842
Compare
Signed-off-by: Maisem Ali <maisem@tailscale.com>
Signed-off-by: Maisem Ali <maisem@tailscale.com>
maisem
pushed a commit
that referenced
this pull request
Nov 12, 2022
Exposes a REST-y API for interacting with the profile switching introduced in #6022. Signed-off-by: Mihai Parparita <mihai@tailscale.com>
mihaip
added a commit
that referenced
this pull request
Nov 16, 2022
It was previously only invoked from the CLI, which only runs from the main .app. However, starting with #6022 we also invoke it from the network extension. Signed-off-by: Mihai Parparita <mihai@tailscale.com>
mihaip
added a commit
that referenced
this pull request
Nov 16, 2022
It was previously only invoked from the CLI, which only runs from the main .app. However, starting with #6022 we also invoke it from the network extension. Signed-off-by: Mihai Parparita <mihai@tailscale.com>
mihaip
added a commit
that referenced
this pull request
Jan 27, 2023
The iOS has a command to reset the persisted state of the app, but it was doing its own direct keychain manipulation. This proved to be brittle (since we changed how preferences are stored with #6022), so we instead add a LocalAPI endpoint to do do this, which can be updated in tandem. This clears the same state as the iOS implementation (tailscale/corp#3186), that is the machine key and preferences (which includes the node key). Notably this does not clear the logtail ID, so that logs from the device still end up in the same place. Updates tailscale/corp#8923 Signed-off-by: Mihai Parparita <mihai@tailscale.com>
mihaip
added a commit
that referenced
this pull request
Jan 28, 2023
The iOS has a command to reset the persisted state of the app, but it was doing its own direct keychain manipulation. This proved to be brittle (since we changed how preferences are stored with #6022), so we instead add a LocalAPI endpoint to do do this, which can be updated in tandem. This clears the same state as the iOS implementation (tailscale/corp#3186), that is the machine key and preferences (which includes the node key). Notably this does not clear the logtail ID, so that logs from the device still end up in the same place. Updates tailscale/corp#8923 Signed-off-by: Mihai Parparita <mihai@tailscale.com>
mihaip
added a commit
that referenced
this pull request
Jan 28, 2023
The iOS has a command to reset the persisted state of the app, but it was doing its own direct keychain manipulation. This proved to be brittle (since we changed how preferences are stored with #6022), so we instead add a LocalAPI endpoint to do do this, which can be updated in tandem. This clears the same state as the iOS implementation (tailscale/corp#3186), that is the machine key and preferences (which includes the node key). Notably this does not clear the logtail ID, so that logs from the device still end up in the same place. Updates tailscale/corp#8923 Signed-off-by: Mihai Parparita <mihai@tailscale.com>
mihaip
added a commit
that referenced
this pull request
Jan 28, 2023
The iOS has a command to reset the persisted state of the app, but it was doing its own direct keychain manipulation. This proved to be brittle (since we changed how preferences are stored with #6022), so we instead add a LocalAPI endpoint to do do this, which can be updated in tandem. This clears the same state as the iOS implementation (tailscale/corp#3186), that is the machine key and preferences (which includes the node key). Notably this does not clear the logtail ID, so that logs from the device still end up in the same place. Updates tailscale/corp#8923 Signed-off-by: Mihai Parparita <mihai@tailscale.com>
mihaip
added a commit
that referenced
this pull request
Jan 28, 2023
The iOS has a command to reset the persisted state of the app, but it was doing its own direct keychain manipulation. This proved to be brittle (since we changed how preferences are stored with #6022), so we instead add a LocalAPI endpoint to do do this, which can be updated in tandem. This clears the same state as the iOS implementation (tailscale/corp#3186), that is the machine key and preferences (which includes the node key). Notably this does not clear the logtail ID, so that logs from the device still end up in the same place. Updates tailscale/corp#8923 Signed-off-by: Mihai Parparita <mihai@tailscale.com>
coadler
pushed a commit
to coder/tailscale
that referenced
this pull request
Feb 2, 2023
Exposes a REST-y API for interacting with the profile switching introduced in tailscale#6022. Updates tailscale#713 Signed-off-by: Mihai Parparita <mihai@tailscale.com>
coadler
pushed a commit
to coder/tailscale
that referenced
this pull request
Feb 2, 2023
It was previously only invoked from the CLI, which only runs from the main .app. However, starting with tailscale#6022 we also invoke it from the network extension. Signed-off-by: Mihai Parparita <mihai@tailscale.com>
coadler
pushed a commit
to coder/tailscale
that referenced
this pull request
Feb 2, 2023
The iOS has a command to reset the persisted state of the app, but it was doing its own direct keychain manipulation. This proved to be brittle (since we changed how preferences are stored with tailscale#6022), so we instead add a LocalAPI endpoint to do do this, which can be updated in tandem. This clears the same state as the iOS implementation (tailscale/corp#3186), that is the machine key and preferences (which includes the node key). Notably this does not clear the logtail ID, so that logs from the device still end up in the same place. Updates tailscale/corp#8923 Signed-off-by: Mihai Parparita <mihai@tailscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Maisem Ali maisem@tailscale.com
Updates #713