Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tstun, wgengine/magicsock: enable vectorized I/O on Linux. #6663

Merged
merged 1 commit into from Dec 9, 2022

Conversation

jwhited
Copy link
Contributor

@jwhited jwhited commented Dec 7, 2022

This commit updates the wireguard-go dependency and implements the
necessary changes to the tun.Device and conn.Bind implementations to
support passing vectors of packets in tailscaled.

Signed-off-by: Jordan Whited jordan@tailscale.com
Signed-off-by: James Tucker james@tailscale.com
Co-authored-by: James Tucker james@tailscale.com

@jwhited jwhited marked this pull request as ready for review December 7, 2022 22:50
Copy link
Member

@sailorfrag sailorfrag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I understand what the magicsock changes are doing but admittedly it's kind of hard to follow. That's not your fault, that's preexisting. The rest was clear enough.

wgengine/magicsock/magicsock.go Show resolved Hide resolved
wgengine/magicsock/magicsock.go Show resolved Hide resolved
wgengine/magicsock/magicsock.go Outdated Show resolved Hide resolved
wgengine/magicsock/magicsock.go Outdated Show resolved Hide resolved
@jwhited jwhited force-pushed the tailscale-vector-io-review branch 2 times, most recently from 52ecbe4 to 294406f Compare December 9, 2022 01:13
This commit updates the wireguard-go dependency and implements the
necessary changes to the tun.Device and conn.Bind implementations to
support passing vectors of packets in tailscaled. This significantly
improves throughput performance on Linux.

Updates #414

Signed-off-by: Jordan Whited <jordan@tailscale.com>
Signed-off-by: James Tucker <james@tailscale.com>
Co-authored-by: James Tucker <james@tailscale.com>
@jwhited jwhited merged commit 76389d8 into main Dec 9, 2022
@jwhited jwhited deleted the tailscale-vector-io-review branch December 9, 2022 01:58
kradalby pushed a commit that referenced this pull request Dec 22, 2022
This commit updates the wireguard-go dependency and implements the
necessary changes to the tun.Device and conn.Bind implementations to
support passing vectors of packets in tailscaled. This significantly
improves throughput performance on Linux.

Updates #414

Signed-off-by: Jordan Whited <jordan@tailscale.com>
Signed-off-by: James Tucker <james@tailscale.com>
Co-authored-by: James Tucker <james@tailscale.com>
coadler pushed a commit to coder/tailscale that referenced this pull request Feb 2, 2023
…ale#6663)

This commit updates the wireguard-go dependency and implements the
necessary changes to the tun.Device and conn.Bind implementations to
support passing vectors of packets in tailscaled. This significantly
improves throughput performance on Linux.

Updates tailscale#414

Signed-off-by: Jordan Whited <jordan@tailscale.com>
Signed-off-by: James Tucker <james@tailscale.com>
Co-authored-by: James Tucker <james@tailscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants