ipn/ipnlocal: move handling of expired nodes to LocalBackend #6937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-d
force-pushed
the
andrew/expired-nodes-localbackend
branch
from
eed537b
to
2def59d
Compare
bradfitz
approved these changes
Jan 13, 2023
| // Copyright (c) 2023 Tailscale Inc & AUTHORS All rights reserved. | ||
| // Use of this source code is governed by a BSD-style | ||
| // license that can be found in the LICENSE file. | ||
|
|
There was a problem hiding this comment.
Maybe a little file comment up here? (not attached to copyright or package line)
andrew-d
force-pushed
the
andrew/expired-nodes-localbackend
branch
from
2def59d
to
3b65f7c
Compare
bradfitz
reviewed
Jan 13, 2023
andrew-d
force-pushed
the
andrew/expired-nodes-localbackend
branch
from
3b65f7c
to
7394128
Compare
In order to be able to synthesize a new NetMap when a node expires, have LocalBackend start a timer when receiving a new NetMap that fires slightly after the next node expires. Additionally, move the logic that updates expired nodes into LocalBackend so it runs on every netmap (whether received from controlclient or self-triggered). Updates #6932 Signed-off-by: Andrew Dunham <andrew@du.nham.ca> Change-Id: I833390e16ad188983eac29eb34cc7574f555f2f3
andrew-d
force-pushed
the
andrew/expired-nodes-localbackend
branch
from
7394128
to
431b06a
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be able to synthesize a new NetMap when a node expires, have LocalBackend start a timer when receiving a new NetMap that fires slightly after the next node expires. Additionally, move the logic that updates expired nodes into LocalBackend so it runs on every netmap (whether received from controlclient or self-triggered).
Updates #6932
Signed-off-by: Andrew Dunham andrew@du.nham.ca
Change-Id: I833390e16ad188983eac29eb34cc7574f555f2f3