cmd/tailscale/cli: make "update" work on Windows #6996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return "", err | ||
| } | ||
| defer f.Close() | ||
| f2, err := os.CreateTemp("", "tailscale-updater-*.exe") |
There was a problem hiding this comment.
This seems like this might trigger Windows Defender, writing out an executable and running it.
There was a problem hiding this comment.
Dunno?
It didn't for me. I don't think I have any of the relevant things turned off. Doesn't look like it.
There was a problem hiding this comment.
Windows Defender is kind of a black box wrt this, hard to say. This is a very common thing for updaters to do, though.
bradfitz
force-pushed
the
bradfitz/win_update
branch
6 times, most recently
from
1d01d3c
to
513968c
Compare
bradfitz
changed the title
bradfitz
force-pushed
the
bradfitz/win_update
branch
from
513968c
to
663ae70
Compare
|
Okay, waiting on @dblohm7 to do another pass over it. I'll resume work on Debian support. |
mayakacz
approved these changes
Jan 19, 2023
| @@ -24,7 +37,7 @@ import ( | |||
| var updateCmd = &ffcli.Command{ | |||
| Name: "update", | |||
| ShortUsage: "update", | |||
| ShortHelp: "Update Tailscale to the latest/different version", | |||
| ShortHelp: "[ALPHA] Update Tailscale to the latest/different version", | |||
There was a problem hiding this comment.
Have we used "Alpha" or other warnings in other parts of the CLI? Not afaik?
If not, then not sure we should include, unless we're going to add throughout the CLI.
There was a problem hiding this comment.
Yes, we have. I made it match the others:
bradfitz@tsdev:~/src/tailscale.com$ git grep ALPHA
cmd/tailscale/cli/login.go: ShortUsage: "[ALPHA] login [flags]",
cmd/tailscale/cli/serve.go: ShortHelp: "[ALPHA] Serve from your Tailscale node",
cmd/tailscale/cli/serve.go:*** ALPHA; all of this is subject to change ***
cmd/tailscale/cli/switch.go: [ALPHA] switch <name>
cmd/tailscale/cli/switch.go: [ALPHA] switch --list
cmd/tailscale/cli/update.go: ShortHelp: "[ALPHA] Update Tailscale to the latest/different version",
andrew-d
approved these changes
Jan 19, 2023
bradfitz
force-pushed
the
bradfitz/win_update
branch
from
663ae70
to
5c976e9
Compare
dblohm7
requested changes
Jan 19, 2023
bradfitz
force-pushed
the
bradfitz/win_update
branch
2 times, most recently
from
732ea44
to
24c50d3
Compare
bradfitz
force-pushed
the
bradfitz/win_update
branch
from
24c50d3
to
7db362d
Compare
Updates #6995 Co-authored-by: Aaron Klotz <aaron@tailscale.com> Change-Id: I16622f43156a70b6fbc8205239fd489d7378d57b Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
bradfitz
force-pushed
the
bradfitz/win_update
branch
from
7db362d
to
43ab0b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmd/tailscale/cli: make "update" work on Windows
Updates #6995