version, cmd/tailscale: add version.Meta, tailscale version --json #7029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradfitz
force-pushed
the
bradfitz/version_json
branch
from
088059f
to
2e03c70
Compare
DentonGentry
approved these changes
Jan 21, 2023
version/prop.go
Outdated
| // --exclude "*" --dirty --abbrev=200`. | ||
| GitCommit string `json:"gitCommit,omitempty"` | ||
|
|
||
| // GitDirty is whether Go stamped the binary has having dirty version |
There was a problem hiding this comment.
I think "has having" should be "as having"
There was a problem hiding this comment.
Hah, I copy/pasted this from elsewhere that was wrong. Fixed in both places.
Add `tailscale version --json` JSON output mode. This will be used later for a double-opt-in (per node consent like Tailscale SSH + control config) to let admins do remote upgrades via `tailscale update` via a c2n call, which would then need to verify the cmd/tailscale found on disk for running tailscale update corresponds to the running tailscaled, refusing if anything looks amiss. Plus JSON output modes are just nice to have, rather than parsing unstable/fragile/obscure text formats. Updates #6995 Updates #6907 Change-Id: I7821ab7fbea4612f4b9b7bdc1be1ad1095aca71b Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
bradfitz
force-pushed
the
bradfitz/version_json
branch
from
2e03c70
to
4380b49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
tailscale version --jsonJSON output mode. This will be used later for a double-opt-in (per node consent like Tailscale SSH + control config) to let admins do remote upgrades viatailscale updatevia a c2n call, which would then need to verify the cmd/tailscale found on disk for running tailscale update corresponds to the running tailscaled, refusing if anything looks amiss.Plus JSON output modes are just nice to have, rather than parsing unstable/fragile/obscure text formats.
Updates #6995
Updates #6907