envknob, hostinfo, ipn/ipnlocal: add start of opt-in remote update support #7031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradfitz
force-pushed
the
bradfitz/remote_update
branch
from
8c82b12
to
dcb6744
Compare
|
Rebased. PTAL. |
andrew-d
approved these changes
Jan 23, 2023
| return | ||
| } | ||
| res.Started = true | ||
| defer cmd.Wait() |
There was a problem hiding this comment.
There might be a race condition here on Windows:
- We start the update process
tailscale.execopies itself and kicks off the update processmsiexecstops this process during the update before theselfCopyexits(?)- This doesn't return because the process is dead
This seems fairly unlikely, but worth flagging?
| return | ||
| } | ||
|
|
||
| func findCmdTailscale() (string, error) { |
There was a problem hiding this comment.
This is the safe way to do this; not relying on $PATH but checking the location where everything is expected to be 👍
There was a problem hiding this comment.
Left a comment to that effect lest somebody add a PATH check later.
| @@ -77,3 +88,92 @@ func (b *LocalBackend) handleC2N(w http.ResponseWriter, r *http.Request) { | |||
| http.Error(w, "unknown c2n path", http.StatusBadRequest) | |||
| } | |||
| } | |||
|
|
|||
| func (b *LocalBackend) handleC2NUpdate(w http.ResponseWriter, r *http.Request) { | |||
There was a problem hiding this comment.
Thought for the future: we may want some sort of semaphore that prevents two concurrent updates, or if one happened in the past 5 minutes, or something.
There was a problem hiding this comment.
Added TODO with that text
bradfitz
force-pushed
the
bradfitz/remote_update
branch
from
dcb6744
to
7eda973
Compare
andrew-d
reviewed
Jan 23, 2023
bradfitz
force-pushed
the
bradfitz/remote_update
branch
from
7eda973
to
d1945dd
Compare
…pport Updates #6907 Change-Id: I85db4f6f831dd5ff7a9ef4bfa25902607e0c1558 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
bradfitz
force-pushed
the
bradfitz/remote_update
branch
from
d1945dd
to
85f9207
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #6907