cmd/tailscale/cli: implement update for dnf/yum-based distros #8678
Conversation
awly
force-pushed
the
awly/tailscale-update-fedora
branch
from
a586726
to
cb0e3b4
Compare
| track := "unstable" | ||
| if stable, ok := versionIsStable(ver); !ok { | ||
| return fmt.Errorf("malformed version %q", ver) | ||
| } else if stable { | ||
| track = "stable" | ||
| } |
There was a problem hiding this comment.
this is already handled here:
tailscale/cmd/tailscale/cli/update.go
Lines 118 to 132 in cb0e3b4
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
awly
force-pushed
the
awly/tailscale-update-fedora
branch
from
cb0e3b4
to
c26387c
Compare
cmd/tailscale/cli/update.go
Outdated
| switch { | ||
| case haveExecutable("pacman"): | ||
| up.update = up.updateArchLike | ||
| case haveExecutable("apt-get"): |
There was a problem hiding this comment.
Maybe do haveExecutable("apt") || haveExecutable("apt-get")? Belt and suspenders, or overkill? :)
There was a problem hiding this comment.
Left a TODO, since updateDebLike assumes apt-get and will fail if that's missing, even if apt is present.
Will add apt support in a separate PR.
cmd/tailscale/cli/update.go
Outdated
| } else if stable { | ||
| track = "stable" | ||
| } | ||
|
|
||
| if os.Geteuid() != 0 { | ||
| return errors.New("must be root; use sudo") |
There was a problem hiding this comment.
I keep thinking about this. It is bad to simply re-invoke ourselves with sudo?
And/or, should we re-tool the error message to talk about doas (OBSD at least, maybe others?) and runas.exe (Windows, when we get to that point)?
There was a problem hiding this comment.
Added a helper to check running as root and print an OS-appropriate message.
It doesn't look like updateWindows requires admin privileges, at least not explicitly in the code today.
awly
force-pushed
the
awly/tailscale-update-fedora
branch
2 times, most recently
from
8a288e1
to
62704fa
Compare
This is the Fedora family of distros, including CentOS, RHEL and others. Tested in `fedora:latest` and `centos:7` containers. Updates #6995 Signed-off-by: Andrew Lytvynov <awly@tailscale.com>
awly
force-pushed
the
awly/tailscale-update-fedora
branch
from
62704fa
to
25490d6
Compare
…ale#8678) This is the Fedora family of distros, including CentOS, RHEL and others. Tested in `fedora:latest` and `centos:7` containers. Updates tailscale#6995 Signed-off-by: Andrew Lytvynov <awly@tailscale.com> Signed-off-by: Alex Paguis <alex@windscribe.com>
This is the Fedora family of distros, including CentOS, RHEL and others. Tested in
fedora:latestandcentos:7containers.