cmd/tailscale/cli,clientupdate: extract new clientupdate package #8827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awly
force-pushed
the
awly/clientupdate-lib
branch
2 times, most recently
from
6f5b182
to
cd46ec1
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
awly
force-pushed
the
awly/clientupdate-lib
branch
2 times, most recently
from
703ae77
to
8545907
Compare
noncombatant
approved these changes
Aug 10, 2023
| Version string | ||
| // AppStore forces a local app store check, even if the current binary was | ||
| // not installed via an app store. | ||
| AppStore bool |
There was a problem hiding this comment.
Leave it for now, but there is a possible future in which I remove it, FYI.
Extract the self-update logic from cmd/tailscale/cli into a standalone package that could be used from tailscaled later. Updates #6995 Signed-off-by: Andrew Lytvynov <awly@tailscale.com>
awly
force-pushed
the
awly/clientupdate-lib
branch
from
8545907
to
5aa719f
Compare
noncombatant
approved these changes
Aug 10, 2023
alexelisenko
pushed a commit
to Control-D-Inc/tailscale
that referenced
this pull request
Feb 15, 2024
…lscale#8827) Extract the self-update logic from cmd/tailscale/cli into a standalone package that could be used from tailscaled later. Updates tailscale#6995 Signed-off-by: Andrew Lytvynov <awly@tailscale.com> Signed-off-by: Alex Paguis <alex@windscribe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract the self-update logic from cmd/tailscale/cli into a standalone package that could be used from tailscaled later.
The update setup code was refactored a bit compared to original.
The actual
updater.update*methods are largely the same, with some extra validation and calls tolog.Print*/fmt.Print*replaced with the pluggable logger.Updates #6995