Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clientupdate: return NOTREACHED for macsys #8898

Merged
merged 2 commits into from
Aug 16, 2023
Merged

clientupdate: return NOTREACHED for macsys #8898

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c857c9e
clientupdate: return success for macsys
noncombatant Aug 14, 2023
6207aef
clientupdate: return NOTREACHED for macsys
noncombatant Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 1 addition & 6 deletions clientupdate/clientupdate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,12 +588,7 @@ func parseAlpinePackageVersion(out []byte) (string, error) {
}

func (up *updater) updateMacSys() error {
// use sparkle? do we have permissions from this context? does sudo help?
// We can at least fail with a command they can run to update from the shell.
// Like "tailscale update --macsys | sudo sh" or something.
//
// TODO(bradfitz,mihai): implement. But for now:
return errors.ErrUnsupported
return errors.New("NOTREACHED: On MacSys builds, `tailscale update` is handled in Swift to launch the GUI updater")
}

func (up *updater) updateMacAppStore() error {
Expand Down