Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipn/ipnlocal: support most Linuxes in handleC2NUpdate #9114

Merged
merged 2 commits into from
Aug 30, 2023
Merged

ipn/ipnlocal: support most Linuxes in handleC2NUpdate #9114

merged 2 commits into from
Aug 30, 2023

Conversation

noncombatant
Copy link
Contributor

Updates #6995

awly
awly reviewed Aug 28, 2023
View reviewed changes
ipn/ipnlocal/c2n.go Outdated Show resolved Hide resolved
@noncombatant noncombatant force-pushed the noncombatant/moar-linuxen-update branch 2 times, most recently from 00591e0 to 17196fe Compare August 29, 2023 02:24
awly
awly reviewed Aug 29, 2023
View reviewed changes
clientupdate/clientupdate.go Outdated Show resolved Hide resolved
clientupdate/clientupdate.go Show resolved Hide resolved
clientupdate/clientupdate.go Outdated Show resolved Hide resolved
ipn/ipnlocal/c2n.go Outdated Show resolved Hide resolved
ipn/ipnlocal/c2n.go Outdated Show resolved Hide resolved
@noncombatant noncombatant force-pushed the noncombatant/moar-linuxen-update branch 3 times, most recently from be6ce04 to 925a622 Compare August 30, 2023 00:56
awly
awly reviewed Aug 30, 2023
View reviewed changes
clientupdate/clientupdate.go Outdated Show resolved Hide resolved
@noncombatant noncombatant force-pushed the noncombatant/moar-linuxen-update branch from 925a622 to 462edc4 Compare August 30, 2023 17:37
awly
awly approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@awly awly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would still prefer to do validation somewhere within the Updater to make it safer to use.
With the current callers we have, it's ok to keep it in Update only, we can revisit this later if needed.

ipn/ipnlocal/c2n.go Outdated Show resolved Hide resolved
@noncombatant noncombatant force-pushed the noncombatant/moar-linuxen-update branch from 462edc4 to 94ac63d Compare August 30, 2023 18:29
ipn/ipnlocal: support most Linuxes in handleC2NUpdate
184cff8 
Updates #6995

Signed-off-by: Chris Palmer <cpalmer@tailscale.com>
@noncombatant noncombatant force-pushed the noncombatant/moar-linuxen-update branch from 94ac63d to 184cff8 Compare August 30, 2023 21:22
ipn/ipnlocal: support most Linuxes in handleC2NUpdate
7d43770 
Updates #6995

Signed-off-by: Chris Palmer <cpalmer@tailscale.com>
@noncombatant noncombatant force-pushed the noncombatant/moar-linuxen-update branch from 8bd4bc8 to 7d43770 Compare August 30, 2023 21:33
@noncombatant noncombatant merged commit ce1e020 into main Aug 30, 2023
37 checks passed
@noncombatant noncombatant deleted the noncombatant/moar-linuxen-update branch August 30, 2023 21:50
alexelisenko pushed a commit to Control-D-Inc/tailscale that referenced this pull request Feb 15, 2024
@alexelisenko
ipn/ipnlocal: support most Linuxes in handleC2NUpdate (tailscale#9114)
f1bc32e 
* ipn/ipnlocal: support most Linuxes in handleC2NUpdate

Updates tailscale#6995

Signed-off-by: Chris Palmer <cpalmer@tailscale.com>
Signed-off-by: Alex Paguis <alex@windscribe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awly awly awly approved these changes

@twitchyliquid64 twitchyliquid64 twitchyliquid64 left review comments

@bradfitz bradfitz Awaiting requested review from bradfitz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@noncombatant @awly @twitchyliquid64