clientupdate: add linux tarball updates #9144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| files["tailscaled"]++ | ||
| if err := writeFile(tr, tailscaled+".new", 0755); err != nil { | ||
| return fmt.Errorf("failed extracting the new tailscaled binary from %q: %w", path, err) | ||
| } |
There was a problem hiding this comment.
should we have a default: to check for weird junk? If we did that, we'd need a case to account for tailscaled.service, even if just to say "Yes, we got it."
There was a problem hiding this comment.
That would cause updates to fail if we add a new file to the tarball in a new release.
Without default we have some forward-compatibility :)
Base automatically changed from
awly/detect-linux-package-manager-installs
to
main
August 30, 2023 00:36
awly
force-pushed
the
awly/update-tarball
branch
2 times, most recently
from
a67d7cb
to
c343542
Compare
awly
force-pushed
the
awly/update-tarball
branch
6 times, most recently
from
18f7b85
to
4636b4c
Compare
noncombatant
approved these changes
Aug 30, 2023
awly
force-pushed
the
awly/update-tarball
branch
from
4636b4c
to
89c5f8c
Compare
As a fallback to package managers, allow updating tailscale that was self-installed in some way. There are some tricky bits around updating the systemd unit (should we stick to local binary paths or to the ones in tailscaled.service?), so leaving that out for now. Updates #6995 Signed-off-by: Andrew Lytvynov <awly@tailscale.com>
awly
force-pushed
the
awly/update-tarball
branch
from
89c5f8c
to
1f6e075
Compare
alexelisenko
pushed a commit
to Control-D-Inc/tailscale
that referenced
this pull request
Feb 15, 2024
As a fallback to package managers, allow updating tailscale that was self-installed in some way. There are some tricky bits around updating the systemd unit (should we stick to local binary paths or to the ones in tailscaled.service?), so leaving that out for now. Updates tailscale#6995 Signed-off-by: Andrew Lytvynov <awly@tailscale.com> Signed-off-by: Alex Paguis <alex@windscribe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a fallback to package managers, allow updating tailscale that was self-installed in some way. There are some tricky bits around updating the systemd unit (should we stick to local binary paths or to the ones in tailscaled.service?), so leaving that out for now.
Updates #6995