clientupdate,cmd/tailscale/cli: use cli.Stdout/Stderr #9694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case cli.Stdout/Stderr get overriden, all CLI output should use them instead of os.Stdout/Stderr. Update the `update` command to follow this pattern. Updates #cleanup Signed-off-by: Andrew Lytvynov <awly@tailscale.com>
noncombatant
approved these changes
Oct 6, 2023
awly
added a commit
that referenced
this pull request
Oct 10, 2023
This is only relevant for unstable releases and local builds. When local version is newer than upstream, abort release. Also, re-add missing newlines in output that were missed in #9694. Updates #cleanup Signed-off-by: Andrew Lytvynov <awly@tailscale.com>
awly
added a commit
that referenced
this pull request
Oct 10, 2023
This is only relevant for unstable releases and local builds. When local version is newer than upstream, abort release. Also, re-add missing newlines in output that were missed in #9694. Updates #cleanup Signed-off-by: Andrew Lytvynov <awly@tailscale.com>
awly
added a commit
that referenced
this pull request
Oct 11, 2023
This is only relevant for unstable releases and local builds. When local version is newer than upstream, abort release. Also, re-add missing newlines in output that were missed in #9694. Updates #cleanup Signed-off-by: Andrew Lytvynov <awly@tailscale.com>
alexelisenko
pushed a commit
to Control-D-Inc/tailscale
that referenced
this pull request
Feb 15, 2024
In case cli.Stdout/Stderr get overriden, all CLI output should use them instead of os.Stdout/Stderr. Update the `update` command to follow this pattern. Updates #cleanup Signed-off-by: Andrew Lytvynov <awly@tailscale.com> Signed-off-by: Alex Paguis <alex@windscribe.com>
alexelisenko
pushed a commit
to Control-D-Inc/tailscale
that referenced
this pull request
Feb 15, 2024
…e#9733) This is only relevant for unstable releases and local builds. When local version is newer than upstream, abort release. Also, re-add missing newlines in output that were missed in tailscale#9694. Updates #cleanup Signed-off-by: Andrew Lytvynov <awly@tailscale.com> Signed-off-by: Alex Paguis <alex@windscribe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case cli.Stdout/Stderr get overriden, all CLI output should use them instead of os.Stdout/Stderr. Update the
updatecommand to follow this pattern.Updates #cleanup