uirules: add a rule to add anchors to URL-shaped text #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: M. J. Fromberger <fromberger@tailscale.com>
crawshaw
reviewed
Aug 15, 2023
uirules/uirules.go
Outdated
| Value: regexp.MustCompile(`^https?://\S+$`), | ||
| Apply: func(col, s string, _ []string) any { | ||
| if _, err := url.Parse(s); err == nil { | ||
| return template.HTML(fmt.Sprintf(`<a href="%s" referrerpolicy=no-referrer rel=noopener>`, s)) |
There was a problem hiding this comment.
I'm concerned that %s might include a "><script>... from some user data. Am I misunderstanding template.HTML?
There was a problem hiding this comment.
It could in general, but in this case we are only plugging it in if a URL parser accepts it as valid, which should rule out that sort of shenanigan.
There was a problem hiding this comment.
I made it render the URL's string explicitly, so we can be sure we are getting proper escapes.
crawshaw
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: M. J. Fromberger fromberger@tailscale.com