Do not overwrite ACL file that has been changed manually #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knyar
force-pushed
the
knyar/acl_etag
branch
2 times, most recently
from
432ddaa
to
31f0e28
Compare
Overwriting non-default ACL contents is confusing, so now users will be prompted to explicitly import their existing ACL into Terraform if they want to manage it there. This will make overwriting existing contents harder, since after importing Terraform will show a sensible diff in `terraform apply`. Fixes #182.
dsymonds
added a commit
to dsymonds/terraform-provider-tailscale
that referenced
this pull request
Oct 22, 2023
Also document importing tailscale_acl resources, which was supported from tailscale#186.
dsymonds
added a commit
to dsymonds/terraform-provider-tailscale
that referenced
this pull request
Nov 13, 2023
Also document importing tailscale_acl resources, which was supported from tailscale#186.
knyar
pushed a commit
that referenced
this pull request
Nov 13, 2023
Also document importing tailscale_acl resources, which was supported from #186.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overwriting non-default ACL contents is confusing, so now users will be prompted to explicitly import their existing ACL into Terraform if they want to manage it there. This will make overwriting existing contents harder, since after importing Terraform will show a sensible diff in
terraform apply.Fixes #182.