Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Ensure anchored components are always rendered in a stacking context (#…
…3115) * provide `floatingStyles` based on incoming `anchor` information Before this change, we were only providing the `floatingStyles` based on the `isEnabled` state. However, this relies on information that is only available in the next render. Now the styles are provided one render too late. This means, that there will be a moment where the `ListboxOptions` (in case of a `Listbox`) is rendered at the end of the page (and expanding the height of the parent) without positioning it on top of it in a separate layer (due to the `position: absolute;`) The reason this was added was to prevent applying styles to the `ListboxOptions` if it did not require anchoring (aka no `anchor={{…}}` prop is provided). Instead of relying on the `isEnabled` value (which is computed based on information that is only available in the next render), we provide the styles based on the incoming `anchor` information which is available immediately. The cool thing is that Floating UI is already providing a default `position: absolute; top: 0; left: 0;` style. If we apply this, it's already stacked instead of rendering at the end of the page. * update changelog
- Loading branch information