-
Notifications
You must be signed in to change notification settings - Fork 1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
syncing of the input should happen when the value changes internally …
…or externally I also got rid of the manually dispatching of the change event if the value changes from internally. I think the correct mental model is: - That the `Combobox.Input` value should change if the selected value changes from the outside or from the inside. - Note: It should _not_ do that if you are currently typing (once you choose a new value it will re-sync, once you reset (escape / outside click) it will also sync again). - The `onChange`/`onInput` of the `Combobox.Input` itself should only be called if you as the user type something. Not when the value is "synced" based on the selected value. We were currently manually dispatching events which works (to a certain extend) but smelled a bit fishy to me. The manual dispatching of events tried to solve an issue (#1875), but I think this can be solved in 2 other ways that make a bit more sense: 1. (Today) Use the `onBlur` on the input to reset the `query` value to filter options. 2. (In the future) Use an exposed `onClose` (or similar) event to reset your `query` value.
- Loading branch information
1 parent
7a21475
commit a09dd84
Showing
4 changed files
with
88 additions
and
158 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.