Improve overal codebase, use modern tech like esbuild and TypeScript 4!
#1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). headlessui-vue – ./packages/playground-vue🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-vue/8QMN5ZNBbe1HMdKcy9FWJ6fze2FE headlessui-react – ./packages/playground-react🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-react/CM5xxJtZQyf2FghkciuGpEoproEv |
RobinMalfait
force-pushed
the
improve-codebase
branch
from
68883d5
to
1951b1b
Compare
This has a few changes because of the new prettier version.
This will make sure to run a watcher for the actual @headlessui/react package, and start a development server in the playground-react package.
Still not 100% working, but getting there!
This allows you to run `yarn react playground` or `yarn vue playground` from the root.
If you minify the code, then it could happen that the errors are a bit obscure. This will hardcode the component name to improve errors.
RobinMalfait
force-pushed
the
improve-codebase
branch
from
a405fad
to
3fb38d9
Compare
RobinMalfait
changed the title
esbuild and TypeScript 4!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will improve the overal infrastructure of the Headless UI repo.
The biggest change is the removal of TSDX since it is outdated and still on TypeScript version 3. This PR introduces esbuild instead. This also allows us to use newer version of TypeScript.