Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Transition component's incorrect cleanup and order of events #1803

Merged
merged 9 commits into from
Sep 1, 2022
Merged

Fix Transition component's incorrect cleanup and order of events #1803

merged 9 commits into from
Sep 1, 2022

Commits on Aug 31, 2022

  1. improve tracking of transitionableChildren

    @RobinMalfait
    RobinMalfait committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    064fc4e View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. remove weird outlier snapshots 

    If anything is still wrong the tests will still fail but the diffs will
be easier to read.
    @RobinMalfait
    RobinMalfait committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    a7aac44 View commit details
    Browse the repository at this point in the history

  2. remove event handling from useTransition

    @RobinMalfait
    RobinMalfait committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    384e36c View commit details
    Browse the repository at this point in the history

  3. handle before/after events in Transition directly

    @RobinMalfait
    RobinMalfait committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    4b0d346 View commit details
    Browse the repository at this point in the history

  4. fix incorrect logic bug in tests

    @RobinMalfait
    RobinMalfait committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    06ddbfe View commit details
    Browse the repository at this point in the history

  5. add very explicit test for transition event order

    @RobinMalfait
    RobinMalfait committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    159eae7 View commit details
    Browse the repository at this point in the history

  6. ignore flakey tests for now 

    We will get back to these!
    @RobinMalfait
    RobinMalfait committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    8b9a9ab View commit details
    Browse the repository at this point in the history

  7. ensure cancellation of transitions works properly

    @RobinMalfait
    RobinMalfait committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    7747d67 View commit details
    Browse the repository at this point in the history

  8. update changelog

    @RobinMalfait
    RobinMalfait committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    bf3cab3 View commit details
    Browse the repository at this point in the history