Allow root containers from the Dialog component in the FocusTrap component
#2322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RobinMalfait
changed the title
FocusTrap in all allowed containersDialog component in the FocusTrap component
RobinMalfait
force-pushed
the
fix/issue-2312
branch
from
7ab9bd1
to
f6ea22a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the
FocusTrapis not properly handled for allowed root containers (like 3rd party containers).When using the
FocusTrapcomponent inside of theDialog, then only theDialogwas considered one of the containers. However, we should keep all the allowed containers into account just like how we handle them for outside click and escape behaviour.Fixes: #2312