Fix restore focus to buttons in Safari, when Dialog component closes
#2326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RobinMalfait
force-pushed
the
fix/issue-1643
branch
from
34a9ccb
to
d1b5f5e
Compare
RobinMalfait
force-pushed
the
fix/issue-1643
branch
from
d1b5f5e
to
e2fbb96
Compare
RobinMalfait
force-pushed
the
fix/issue-1643
branch
from
e2fbb96
to
1001687
Compare
Includes a generic `Button` component that has explicit focus styles.
Safari doesn't "focus" buttons when you mousedown on them. This means that we don't capture the correct element to restore focus to when closing a `Dialog` for example. Now, we will make sure to keep track of a list of last "focused" items. We do this by also capturing elements when you "click", "mousedown" or "focus".
RobinMalfait
force-pushed
the
fix/issue-1643
branch
from
1001687
to
2ec9f3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in Safari where the focus is not properly restored to the element that originally opened the
Dialogcomponent.This is because Safari doesn't "focus", the button when you click on it. We were relying on this (because we used the
document.activeElement).Now we will keep track of "focused" items (even when you click them), and use that as a restoreable element.
Fixes: #1643