Fix `XYZPropsWeControl` and cleanup internal TypeScript types #2329

The idea behind the `PropsWeControl` is that we can omit all the fields that we are controlling entirely. In this case, passing a prop like `role`, but if we already set the role ourselves then the prop won't do anything at all. This is why we want to alert the end user that it is an "error". It can also happen that we "control" the value by default, but keep incoming props into account. For example we generate a unique ID for most components, but you can provide your own to override it. In this case we _don't_ want to include the ID in the `XYZPropsWeControl`. Additionally, we introduced some functionality months ago where we call event callbacks (`onClick`, ...) from the incoming props before our own callbacks. This means that by definition all `onXYZ` callbacks can be provided.

Whenever we explicitly provide custom types for certain props, then we make sure to omit those keys first from the original props (of let's say an `input`). This is important so that TypeScript doesn't try to "merge" those types together.

The `console.log` is typed as `(...args: any[]) => void` which means that it will incorrectly mark its incoming data as `any` as well. Converting it to `x => console.log(x)` makes TypeScript happy. Or in this case, angry since it found a bug. This is required because it _can_ be that your value (e.g.: the value of a Combobox) is an object (e.g.: a `User`), but it is also nullable. Therefore we can provide the value `null`. This would mean that eventually this resolves to `keyof null` which is `never`, but we just want a string in this case. ```diff -export type ByComparator<T> = (keyof T & string) | ((a: T, b: T) => boolean) +export type ByComparator<T> = + | (T extends null ? string : keyof T & string) + | ((a: T, b: T) => boolean) ```

+ add `attrs.class` as well

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix `XYZPropsWeControl` and cleanup internal TypeScript types #2329

Fix `XYZPropsWeControl` and cleanup internal TypeScript types #2329

Commits on Mar 2, 2023

Fix XYZPropsWeControl and cleanup internal TypeScript types #2329

Fix XYZPropsWeControl and cleanup internal TypeScript types #2329

Commits on Mar 2, 2023

Fix `XYZPropsWeControl` and cleanup internal TypeScript types #2329

Fix `XYZPropsWeControl` and cleanup internal TypeScript types #2329