Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "outside click" behaviour in combination with 3rd party libraries #2572

Merged
merged 4 commits into from
Jul 3, 2023

Commits on Jul 3, 2023

  1. listen for both mousedown and pointerdown events

    This is necessary for calculating the target where the focus will
    eventually move to. Some other libraries will use an
    `event.preventDefault()` and if we are not listening for all "down"
    events then we might not capture the necessary target.
    
    We already tried to ensure this was always captured by using the
    `capture` phase of the event but that's not enough.
    
    This change won't be enough on its own, but this will improve the
    experience with certain 3rd party libraries already.
    RobinMalfait committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    4238229 View commit details
    Browse the repository at this point in the history
  2. refactor one-liners

    RobinMalfait committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    bbe103c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4701a3b View commit details
    Browse the repository at this point in the history
  4. update changelog

    RobinMalfait committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    5b5f6ec View commit details
    Browse the repository at this point in the history