Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue breaking change #279

Merged
merged 4 commits into from Mar 15, 2021
Merged

Vue breaking change #279

merged 4 commits into from Mar 15, 2021

Conversation

RobinMalfait
Copy link
Collaborator

@RobinMalfait RobinMalfait commented Mar 15, 2021

  • bump Vue
  • ensure we reference the vite.config.js
  • fix event name casing

@vercel
Copy link

vercel bot commented Mar 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

headlessui-react – ./packages/@headlessui-react

🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-react/McsgvVHajRBYyVgQgcZ3Gd4hhUyL
✅ Preview: https://headlessui-react-git-vue-breaking-change-tailwindlabs.vercel.app

headlessui-vue – ./packages/@headlessui-vue

🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-vue/E3qUWLS3988rWLANPEJMFTjS7qt4
✅ Preview: https://headlessui-vue-git-vue-breaking-change-tailwindlabs.vercel.app

Vue broke this in a 3.0.5 release, it still worked in 3.0.4.

Fixes: #267
@RobinMalfait RobinMalfait changed the title vue breaking change Vue breaking change Mar 15, 2021
@RobinMalfait RobinMalfait merged commit 4648332 into develop Mar 15, 2021
@RobinMalfait RobinMalfait deleted the vue-breaking-change branch March 15, 2021 14:50
This was referenced Mar 15, 2021
RobinMalfait added a commit that referenced this pull request Mar 22, 2021
* bump Vue

* ensure we reference the vite.config.js

* fix event name casing

Vue broke this in a 3.0.5 release, it still worked in 3.0.4.

Fixes: #267

* handle throwing while rendering a better in tests
RobinMalfait added a commit that referenced this pull request Mar 26, 2021
* bump Vue

* ensure we reference the vite.config.js

* fix event name casing

Vue broke this in a 3.0.5 release, it still worked in 3.0.4.

Fixes: #267

* handle throwing while rendering a better in tests
RobinMalfait added a commit that referenced this pull request Apr 2, 2021
* bump Vue

* ensure we reference the vite.config.js

* fix event name casing

Vue broke this in a 3.0.5 release, it still worked in 3.0.4.

Fixes: #267

* handle throwing while rendering a better in tests
@RobinMalfait RobinMalfait mentioned this pull request Apr 2, 2021
RobinMalfait added a commit that referenced this pull request Apr 2, 2021
* fix unique symbol error (#248)

* Vue breaking change (#279)

* bump Vue

* ensure we reference the vite.config.js

* fix event name casing

Vue broke this in a 3.0.5 release, it still worked in 3.0.4.

Fixes: #267

* handle throwing while rendering a better in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant