Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure panels re-register when IDs are calculated in React < 18 #2883

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

thecrypticace
Copy link
Contributor

Fixes #2882

Copy link

vercel bot commented Dec 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
headlessui-react ❌ Failed (Inspect) Apr 12, 2024 3:16pm
headlessui-vue ❌ Failed (Inspect) Apr 12, 2024 3:16pm

@camsloanftc
Copy link

Just wanted to confirm this is an issue we are experiencing on our team and was curious if this may go in soon. Thanks!

@RobinMalfait RobinMalfait changed the base branch from main to 1.x April 12, 2024 15:09
@RobinMalfait RobinMalfait merged commit 2b161b3 into 1.x Apr 12, 2024
6 of 8 checks passed
@RobinMalfait RobinMalfait deleted the fix/reregister-tab-panel-id branch April 12, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabs Component Accessibility - aria-controls Value Issue in React 17
3 participants