Expose --input-width and --button-width CSS variables on the ComboboxOptions component
#3057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RobinMalfait
changed the title
--input-width and --button-width variables on the ComboboxOptions component--input-width and --button-width CSS variables on the ComboboxOptions component
RobinMalfait
force-pushed
the
feat/add-combobox-input-width
branch
from
59d313d
to
232aecd
Compare
reinink
approved these changes
Mar 26, 2024
This was referenced May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the
--input-widthand--button-widthCSS variables in theComboboxOptionscomponent.This allows users to make the
ComboboxOptionscomponent the same width as theComboboxInputorComboboxButtonor a combination of both.The reason I added both is just because it doesn't hurt to have both, and when testing it on the countries example (https://headlessui-react-git-feat-add-combobox-input-width-tailwindlabs.vercel.app/combobox/combobox-countries) it was useful to have both.