Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default tag from div to Fragment on Transition components #3110

Merged
merged 10 commits into from
Apr 19, 2024

Commits on Apr 18, 2024

  1. Configuration menu
    Copy the full SHA
    ee252b3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c9b37d2 View commit details
    Browse the repository at this point in the history
  3. only error on missing ref if it's actually required

    If the `<Transition />` component "root" is used as a root placeholder
    (for state management) and not making actual transitions itself, then we
    don't require a `ref` element.
    RobinMalfait committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    2b59749 View commit details
    Browse the repository at this point in the history
  4. add test to ensure we don't error on missing ref when not required

    + add `className="…"` to some places to indicate that we _do_ want to
      perform a transition and thus have to fail if the `ref` is missing.
    RobinMalfait committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    58725bc View commit details
    Browse the repository at this point in the history
  5. improve requiresRef check

    Also ensure that a ref is required if the `as` prop is provided and
    it's not a `Fragment`
    RobinMalfait committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    dea822b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    312a52c View commit details
    Browse the repository at this point in the history
  7. fix broken tests

    These tests were rendering a `Debug` element that didn't render any DOM
    nodes. Adding `as="div"` ensures that we are forwarding the ref
    correctly.
    RobinMalfait committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    3970e64 View commit details
    Browse the repository at this point in the history
  8. update changelog

    RobinMalfait committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    5bdb4cc View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    99698a4 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Tweak changelog

    reinink committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    7fced21 View commit details
    Browse the repository at this point in the history