Use useId instead of React internals
#3254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These may break in any React release which may result in blocking the ecosystem from seemlessly upgrading to new React releases. We can use `useId` instead which is available since React 18.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
No need to use `useStableCollectionKey` anymore
|
Hey! Thanks for the PR, I did inline the |
This was referenced May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These may break in any React release which may result in blocking the ecosystem from seemlessly upgrading to new React releases.
We can use
useIdinstead which is available since React 18.Keep in mind that the whole hook is not safe in concurrent rendering. It increments
renderduring render but only decrements in an effect cleanup. React may render multiple times before actually committing. The keys would leak in those scenarios (e.g. when a sibling suspends).Closes #3167