Allow Tab and Shift+Tab when Listbox is open
#3284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thecrypticace
approved these changes
Jun 11, 2024
This will make it consistent with the `Menu` and the ARIA Authoring Practices Guide.
RobinMalfait
force-pushed
the
fix/issue-3272
branch
from
8a3bb30
to
d13c79b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the behavior of the
Listboxcomponent and allows you to use tab and shift+tab and it will go to the next or previous focusable element respectively.Before this we used to focus trap, but now we will be consistent with the existing
ComboboxandMenucomponents. This also now reflects the ARIA Authoring Practices Guide.Fixes: #3272