Fix hanging tests when using anchor prop
#3357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing using this playground example, so cleaned it up to be more modern using newer components, transition prop and so on.
Let's make it a CSS problem instead of a JS problem. The `round(up, <valueToRound>, <roundingInterval>)` will behave similar to a `Math.ceil()` that we had in the JS implementation. See: https://developer.mozilla.org/en-US/docs/Web/CSS/round
I want to re-enable this in the future, but unfortunately for now we can't use it because Chrome only introduced support for this in the last 2 months. This reverts commit daac60d45ec3f02b324d0d8b18078a995e885733.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RobinMalfait
commented
Jul 3, 2024
| let maxHeight = element.style.maxHeight | ||
| if (parseFloat(maxHeight) !== parseInt(maxHeight)) { | ||
| element.style.maxHeight = `${Math.ceil(parseFloat(maxHeight))}px` | ||
| let maxHeight = window.getComputedStyle(element).maxHeight |
There was a problem hiding this comment.
Used getComputedStyle to resolve the calculated min(var(--anchor-max-height, 100vh), ${availableHeight}px) value
thecrypticace
approved these changes
Jul 3, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where your tests could hang (due to an infinite loop) when testing components using the
anchorprop in a JSDOM based environment.The issue that we were causing an infinite loop because some computation ended up resulting in
NaN. There is also a very elegant purely CSS based solution (usinground()) to the underlying problem, but it just got support in Chrome, so for now we will just fix the issue.Fixes: #3339
Fixes: #3294