fix Listbox and Switch v-model typescript error #459
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Better vue link * add better React link Co-authored-by: Robin Malfait <malfait.robin@gmail.com>
* enable NoScroll feature for the initial useFocusTrap hook Once you are using Tab and Shift+Tab it does the scrolling. Fixes: #345 * update changelog
…)" This reverts commit 19590b0. Solution is not 100% correct, so will revert for now!
* make search case insensitive for the listbox * make search case insensitive for the menu
* add `disabled` prop to RadioGroup and RadioGroup Option Also did some general cleanup which in turn fixed an issue where the RadioGroup is unreachable when a value is used that doesn't exist in the list of options. Fixes: #378 * update changelog
Match RadioGroupOption value types to match modelValue allowed types for RadioGroup
* chore(CI): update main workflow * Update main.yml
* re-export the `screen` utility for quick debugging purposes * stop event propagation when clicking inside a Dialog Fixes: #414
* Make sure that `Escape` only closes the top most Dialog * update changelog
* add defaultOpen prop to Disclosure component * update changelog
|
@ananni13 is attempting to deploy a commit to the Tailwind Labs Team on Vercel. A member of the Team first needs to authorize it. |
RobinMalfait
added a commit
that referenced
this pull request
Apr 28, 2021
|
Hey! Thank you for your PR! I also rebased and updated the changelog, I created a new PR for this but referenced your original commit so that you are still a contributor. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #368
Fixes #457
Removed default prop values for Listbox
modelValueand ListboxOptionvalue.RadioGroup and RadioGroupOption are already written like this and don't cause any typescript errors.
I also included the Switch fix mentioned here: #368 (comment)