Expose close functionality #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Popover.Panel` components (React)
…d `Disclosure.Panel` components (React)
…PopoverPanel` components (Vue)
…d `DisclosurePanel` components (Vue)
|
This pull request is being automatically deployed with Vercel (learn more). headlessui-react – ./packages/@headlessui-react🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-react/NYXKmURxkNvVZ3Nr4hp53LJBXQDP headlessui-vue – ./packages/@headlessui-vue🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-vue/ERpSUEPa4hGkt1591hdob8N9cApz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the
Popover.Buttoninside aPopover.Paneland aDisclosure.Buttoninside aDisclosure.Panel, we will now expose aclosefunction in the render prop. This will give you a bit more control over how you can close theDisclosureandPopover.The
closefunction is exposed on the following components:PopoverPopover.Panel&PopoverPanelDisclosureDisclosure.Panel&DisclosurePanelWhen you call the
closefunction with no arguments, then we will restore the focus to thePopover.ButtonorDisclosure.Buttonfor accessibility purposes.You can also passthrough an actual element, or a ref to focus that element instead.