Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure calls to forwardRef are marked as pure #1192

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Make sure calls to forwardRef are marked as pure #1192

merged 2 commits into from
Jun 17, 2024

Conversation

thecrypticace
Copy link
Contributor

React.forwardRef should always be marked as pure and doing so can help with tree shaking in some build tools.

Fixes #1171

RobinMalfait
RobinMalfait approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@RobinMalfait RobinMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Shall we do a patch release for this one?

@thecrypticace
Copy link
Contributor Author

sweet — yeah let's do a patch for this one

@thecrypticace thecrypticace merged commit e2e487f into master Jun 17, 2024
1 check passed
@thecrypticace thecrypticace deleted the fix/pure-forward-ref branch June 17, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobinMalfait RobinMalfait RobinMalfait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tree-shakable issues when building a library on top of heroicons and vite
2 participants
@thecrypticace @RobinMalfait