Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix React ref type #903

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

alexandernanberg
Copy link
Contributor

Fix ref types for React

E.g. this should be valid

function App() {
  const ref = useRef<SVGSVGElement | null>(null)
  return <Icon ref={ref} />
}

Also changes React.ComponentProps<'svg'> to React.SVGProps<SVGSVGElement> which is what React internally uses for <svg> elements

@thecrypticace thecrypticace merged commit f53375d into tailwindlabs:master Jan 25, 2023
@thecrypticace
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants